URL: https://github.com/freeipa/freeipa/pull/5895
Author: flo-renaud
 Title: #5895: webui tests: close notification when revoking cert
Action: opened

PR body:
"""
When a cert is revoked, a notification is displayed
and may obscure the buttons. Make sure to close the
notification before moving to the next step.

Fixes: https://pagure.io/freeipa/issue/8911
"""

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/5895/head:pr5895
git checkout pr5895
From 04145a4cdfa55bdb530f57236cb9022544a58bce Mon Sep 17 00:00:00 2001
From: Florence Blanc-Renaud <f...@redhat.com>
Date: Tue, 13 Jul 2021 18:38:22 +0200
Subject: [PATCH 1/2] webui tests: close notification when revoking cert

When a cert is revoked, a notification is displayed
and may obscure the buttons. Make sure to close the
notification before moving to the next step.

Fixes: https://pagure.io/freeipa/issue/8911
---
 ipatests/test_webui/test_cert.py | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/ipatests/test_webui/test_cert.py b/ipatests/test_webui/test_cert.py
index 53dc76faae5..488af6bb16d 100644
--- a/ipatests/test_webui/test_cert.py
+++ b/ipatests/test_webui/test_cert.py
@@ -107,6 +107,8 @@ def _add_and_revoke_cert(self, reason='1'):
         self.action_list_action('revoke_cert', False)
         self.select('select[name=revocation_reason]', reason)
         self.dialog_button_click('ok')
+        self.assert_notification(assert_text='Certificate revoked')
+        self.close_notifications()
         self.navigate_to_entity(ENTITY)
 
         return cert

From 76b61ba82f4c69ce5d2964f07796252b57901a1d Mon Sep 17 00:00:00 2001
From: Florence Blanc-Renaud <f...@redhat.com>
Date: Tue, 13 Jul 2021 18:41:24 +0200
Subject: [PATCH 2/2] temp commit

---
 .freeipa-pr-ci.yaml                        |  2 +-
 ipatests/prci_definitions/temp_commit.yaml | 25 +++++++++++-----------
 2 files changed, 14 insertions(+), 13 deletions(-)

diff --git a/.freeipa-pr-ci.yaml b/.freeipa-pr-ci.yaml
index abcf8c5b634..80656690080 120000
--- a/.freeipa-pr-ci.yaml
+++ b/.freeipa-pr-ci.yaml
@@ -1 +1 @@
-ipatests/prci_definitions/gating.yaml
\ No newline at end of file
+ipatests/prci_definitions/temp_commit.yaml
\ No newline at end of file
diff --git a/ipatests/prci_definitions/temp_commit.yaml b/ipatests/prci_definitions/temp_commit.yaml
index af5885d0af2..b3827c84c63 100644
--- a/ipatests/prci_definitions/temp_commit.yaml
+++ b/ipatests/prci_definitions/temp_commit.yaml
@@ -47,7 +47,7 @@ topologies:
     memory: 14500
 
 jobs:
-  fedora-latest/build:
+  pki-fedora/build:
     requires: []
     priority: 100
     job:
@@ -55,20 +55,21 @@ jobs:
       args:
         git_repo: '{git_repo}'
         git_refspec: '{git_refspec}'
-        template: &ci-master-latest
-          name: freeipa/ci-master-f33
-          version: 0.0.9
+        template: &pki-master-latest
+          name: freeipa/pki-master-f34
+          version: 0.0.1
         timeout: 1800
         topology: *build
 
-  fedora-latest/temp_commit:
-    requires: [fedora-latest/build]
+  pki-fedora/test_webui_cert:
+    requires: [pki-fedora/build]
     priority: 50
     job:
-      class: RunPytest
+      class: RunWebuiTests
       args:
-        build_url: '{fedora-latest/build_url}'
-        test_suite: test_integration/test_REPLACEME.py
-        template: *ci-master-latest
-        timeout: 3600
-        topology: *master_1repl_1client
+        build_url: '{pki-fedora/build_url}'
+        update_packages: True
+        test_suite: test_webui/test_cert.py
+        template: *pki-master-latest
+        timeout: 2400
+        topology: *ipaserver
_______________________________________________
FreeIPA-devel mailing list -- freeipa-devel@lists.fedorahosted.org
To unsubscribe send an email to freeipa-devel-le...@lists.fedorahosted.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedorahosted.org/archives/list/freeipa-devel@lists.fedorahosted.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure

Reply via email to