On Mon, 2009-07-20 at 14:40 -0400, Stephen Gallagher wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > On 07/20/2009 02:28 PM, Simo Sorce wrote: > > On Mon, 2009-07-20 at 14:14 -0400, Stephen Gallagher wrote: > >> Explicitly use /var/lib in the sssd.spec > >> > >> The source code currently hardcodes the path to /var/lib, but the > >> sssd.spec relies on the value of %{_sharedstatedir}. This is > >> broken on systems like RHEL5 where %{_sharedstatedir} resolves to > >> /usr/com > >> > > Nack, > > please define a new variable and assign it differently depending on the > > platfrom, either by checking directly for disttags or release names, or > > by using a define > > > > Something like: > > %if 0%{fedora} > 11 > > %define sssd_var_lib %{_sharedstatedir} > > %else > > %define sssd_var_lib /var/lib > > %endif > > > > Then always use %{sssd_var_lib} > > > > Simo. > > > > I disagree. This doesn't make any sense. That statement parses to: > If the sharedstatedir == /var/lib, use sharedstatedir, otherwise, use > /var/lib. It seems incongruous to use another variable there.
No the statement I made is: if Fedora >= 11 use %{_sharedstatedir} otherwise use /var/lib of course the idea is to pass sssd_var_lib to the appropriate ./configure switch > If we're going to nack it, I'd rather we just state outright that we > need to fix the code to always create the pipes in sharedstatedir, > rather than hard-coding /var/lib. Yes, we should not hardcode /var/lib in our source, just do the above int he rpm. > This fix was just meant to hold us over until we get around to doing that. The example I made would still be valid once you have the configure option. You still want to use sharedstatedir in Fedora >= 11 but not in RHEL5. Simo. -- Simo Sorce * Red Hat, Inc * New York _______________________________________________ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel