-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 07/31/2009 11:55 AM, Stephen Gallagher wrote:
> On 07/31/2009 06:02 AM, Jakub Hrozek wrote:
>> On 07/30/2009 08:45 PM, Stephen Gallagher wrote:
>>> I'm going to nack the user notification patch. I think we need to think
>>> some more about this. The sysdb has an interface in place for returning
>>> ENOENT when trying to delete, we're just setting it
>>> state->ignore_not_found = true; in sysdb_delete_entry_send().
>>> I think the correct thing to do would be to modify that function so that
>>> it accepted a boolean value for whether or not to ignore it if it's not
>>> found.
>>> This way, we aren't doing an extra search.
>> I agree, I didn't realize there was this option. Thanks for the review.
> 
>> Attached are three patches:
>> * [PATCH 1/3] Add ignore_not_found parameter to sysdb delete functions
>> changes the sysdb API, its invocations in the code and adds a test for
>> the change
>> * [PATCH 2/3] Use correct return codes
>> The already-acked patch, included for clarity
>> * [PATCH 3/3] Notify user when deleting nonexistent user or group
>> Changes tools code to react with appropriate error message to ENOENT
> 
>>      Jakub
> 
> Ack to all three.
> ------------------------------------------------------------------------
> 
> _______________________________________________
> Freeipa-devel mailing list
> Freeipa-devel@redhat.com
> https://www.redhat.com/mailman/listinfo/freeipa-devel
> 
> 

Pushed to master.
_______________________________________________
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel


- -- 
Stephen Gallagher
RHCE 804006346421761

Looking to carve out IT costs?
www.redhat.com/carveoutcosts/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/

iEYEARECAAYFAkpzF1sACgkQeiVVYja6o6OXNgCeJOL/NqEGHo2CGH52w6JtvDqF
Cb4AniNz+VPRX+wpAqFzfSLZN7lSzaBX
=Md5I
-----END PGP SIGNATURE-----

_______________________________________________
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel

Reply via email to