Martin Nagy wrote:
----- Original Message -----
From: "Rob Crittenden" <rcrit...@redhat.com>
To: "freeipa-devel" <freeipa-devel@redhat.com>
Sent: Tuesday, August 11, 2009 11:12:49 PM GMT +01:00 Amsterdam / Berlin / Bern 
/ Rome / Stockholm / Vienna
Subject: [Freeipa-devel] [PATCH] 250 fix some pylint/pychecker errors

Taking David Malcolm's advice I ran pylint and pychecker against a lot of the IPA code. Much of what it turned up was warnings/complaints about variable names, minor formatting, things like that. But it did also turn up a few bugs (using undefined exceptions, some references to non-existent variables, etc).

There are still a lot of places where we shadow built-in functions (filter is a common one). I see this as a first-pass at it.

I'll consider trying to come up with a config file we can pass to this so we can do some sort of 'make check' to catch errors. Right now the output is so copious it is difficult to tell wheat from chaff without reading carefully.

rob

Ack.
Martin

thanks, pushed to master.

rob

Attachment: smime.p7s
Description: S/MIME Cryptographic Signature

_______________________________________________
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel

Reply via email to