Pavel Zuna wrote:
Rob Crittenden wrote:Pavel Zuna wrote:Sumit noticed, that the HBAC plugin didn't make it into the tree and the patch got lost in the depths of freeipa-devel.I reworked the plugin to meet the current standards and changed GeneraliSedTime to GeneraliZedTime. For now, I put the new parameter type into a separate file in ipalib/plugins/generalizedtime.py. When it's tested enough, we're going to move it to ipalib/parameters.py.The patch also modifies bootstrap-template.ldif to create a cn=hbac container after installing IPA.PavelShouldn't GeneralizedTime be in ipalib? I think GeneralizedTime should have some unit tests, same for hbac. robUpdate: - Now includes extensive unit test for HBAC plugin. - GeneralizedTime was moved to ipalib/parameters. - Minor updated to HBAC plugin, mostly esthetics. Pavel
pushed to master.It would be nice if GeneralizedTime had its own unit tests but I don't want that to hold up this patch.
rob
smime.p7s
Description: S/MIME Cryptographic Signature
_______________________________________________ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
