On Fri, 2010-02-12 at 16:41 -0500, Rob Crittenden wrote:
> This patch does a number of things. I considered breaking it up but it 
> is so interdependent I thought that would make more work.
> 
> The core of this is using the Output tuple defined for the command to 
> determine the order of output. This is a very broad brush, controlling 
> only the summary, entry and value order, but it's a start.
> 
> This also fixes displaying group membership and failed membership 
> modifications. I added a bit of recursion to support that. It may need 
> some more beautification work but the basics are there.
> 
> I've also got all tests passing at 100%. The only thing left to do is to 
> get the framework to return the dn again. Once that works we can remove 
> the hash for all the #dn entries in the tests.
> 
> rob


ack.  pushed to master.

Nice patch, Rob.  The only thing I'd like us to add (in a separate
patch) is to change Output.flags to be a frozenset.  I'm a big fan of
using immutable data types to prevent multi-threading gotchas.

_______________________________________________
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel

Reply via email to