Nalin correctly identified two minor issues in the install/po/Makefile he noticed after my last patch.

The empty rule for the all target is bad style.

The newly added target "mo-files" should have been listed in the .PHONY list.

Neither one should cause problem, but they should be cleaned up.
--
John Dennis <jden...@redhat.com>

Looking to carve out IT costs?
www.redhat.com/carveoutcosts/
>From e957450602e58a026ebd4bb1ef33bfa6e0bc7bc9 Mon Sep 17 00:00:00 2001
From: John Dennis <jden...@redhat.com>
Date: Mon, 22 Feb 2010 16:50:37 -0500
Subject: [PATCH] minor makefile cleanup
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

---
 install/po/Makefile.in |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/install/po/Makefile.in b/install/po/Makefile.in
index 7880e19..f696c17 100644
--- a/install/po/Makefile.in
+++ b/install/po/Makefile.in
@@ -158,10 +158,9 @@ POTFILES = $(PYTHON_POTFILES) $(C_POTFILES)
 
 .SUFFIXES:
 .SUFFIXES: .po .mo
-.PHONY: all create-po update-po update-pot install mostlyclean clean distclean test_lang test
+.PHONY: all create-po update-po update-pot install mostlyclean clean distclean test_lang test mo-files
 
 all:
-	@
 
 SUFFIXES = .po .mo
 
-- 
1.6.6

_______________________________________________
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel

Reply via email to