NACK, this seems to be a patch for code that isn't even in the repository yet. BTW, how is one supposed to apply this patch? Saving the whole email didn't work for me, I had to hand edit it and git-am still complained.
Martin On Tue, 2010-03-02 at 17:01 -0500, John Dennis wrote: > This is a multi-part message in MIME format. > --------------22.214.171.124 > Content-Type: text/plain; charset=UTF-8; format=fixed > Content-Transfer-Encoding: 8bit > > --- > ipaserver/rpcserver.py | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > > --------------126.96.36.199 > Content-Type: text/x-patch; > name="0002-documentation-fix-for-json_decode_binary.patch" > Content-Transfer-Encoding: 8bit > Content-Disposition: attachment; > filename="0002-documentation-fix-for-json_decode_binary.patch" > > diff --git a/ipaserver/rpcserver.py b/ipaserver/rpcserver.py > index 96c4d29..86bdf14 100644 > --- a/ipaserver/rpcserver.py > +++ b/ipaserver/rpcserver.py > @@ -278,8 +278,8 @@ def json_decode_binary(val): > binary value with the decoded binary value. Unlike the encoding problem > where the input might consist of immutable object, all JSON decoded > container are mutable so the conversion could be done in place. However > we > - don't modifying objects in place has side effects which may be > - dangerous. Thus we elect to spend a few more cycles and avoid the > + don't modify objects in place because that might have side effects which > may > + be dangerous. Thus we elect to spend a few more cycles and avoid the > possibility of unintended side effects in favor of robustness. > ''' > > > --------------188.8.131.52-- _______________________________________________ Freeipa-devel mailing list Freeipafirstname.lastname@example.org https://www.redhat.com/mailman/listinfo/freeipa-devel