Martin Nagy wrote:
On 03/04/2010 10:25 PM, Rob Crittenden wrote:
Currently if you pass in an empty update on the cli it won't throw an
error and can be a bit confusing.

rob

I think the change in pwpolicy.py won't preserve the original behaviour:
+        if 'group' in options:
+            group_cn = options['group']
+            del options['group']
+        else:
             group_cn = _global
+
+        if not 'group' in options:
             ...
         else:
             ...

Notice that at the second if, 'group' will never be in options no matter what.

Martin

Yes, I discovered this too. It is fixed in my patch "400 fix pwpolicy plugin" along with a few other things.

rob

_______________________________________________
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel

Reply via email to