On 2010-08-06 17:57, Adam Young wrote:
On 08/06/2010 11:51 AM, Rob Crittenden wrote:
Adam Young wrote:
This code contains the changes to the python code necessary to
support the new web ui. It handles the changes to the baseldap code
necessary to expose the meta data to the front end, as well as the
installation support.


nack.

About 75 tests are failing with this patch. I didn't investigate them
in detail but it looks like memberof isn't being removed after a
member attribute is converted.

wsgi.py has a ton of imports added that aren't being used.

There is an indention change in ipalib/frontend.py that doesn't seem
necessary.

The timelimit patch is gonig to conflict with a timelimit patch I had
submitted previously (patch titled 'use time and search limit values
from cn=ipaconfig'). Not even in terms of code but in forcing a
default that does not tie into the global config. I think I'd rather
have this as an optional argument do no default and autofill is needed.

rob


I'm going to fob this work off on pzuna, as these are his changes that I
just merged in.

I split the baseldap.py changes into 4 patches and posted them on the list a few minutes ago.

Pavel

_______________________________________________
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel

Reply via email to