----- "Adam Young" <ayo...@redhat.com> wrote:

> Should have remembered this approach, standard JS way to deal with 
> undefined values.

admiyo-freeipa-0048-3-Item-Level-Undo.patch

A few notes:

1. You're replying to the wrong thread :)

2. The undo button will only appear when the input field loses focus. Ideally
it should appear as soon as the value is changed, but I'm not sure if it's
possible to do that in JS. This can be addressed in the future.

3. The hint_span doesn't seem to be used consistently in details.js:272-297:

ipa_insert_first_dd(
    jobj, ipa_create_input(obj_name, attr, value[0],hint_span)
);
ipa_insert_other_dd(
    jobj, ipa_create_input(obj_name, attr, value[i],hint_span)
);
ipa_insert_other_dd(
    jobj.next(), _ipa_a_add_template.replace('A', attr)
);
ipa_insert_first_dd(
    jobj, _ipa_a_add_template.replace('A', attr) /*.append( hint_span)*/
);
ipa_insert_first_dd(
    jobj, ipa_create_input(obj_name, attr, '')/*.append( hint_span)*/
);

4. I think the statement on line 341 should be removed because it redefines
   the input variable:

        var input = $("<label>",{html:value.toString()});

5. There is a trailing whitespace on line 337.

Thanks!

--
Endi S. Dewata

_______________________________________________
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel

Reply via email to