Pavel Zuna wrote:
On 10/14/2010 11:16 PM, Rob Crittenden wrote:
Pavel Zuna wrote:
On 10/01/2010 02:47 PM, Pavel Zuna wrote:
Ticket #251

Pavel



New version of patch attached. This time it should work. :) I renamed
the flag from --privateonly to --private. Normal searches do not return
private groups at all, while searches with this flag only return private
groups.

Pavel

This works a lot better than the last patch. The code itself is fine,
I'd just ask that you add a test case for searching for private groups.
The test that is in this patch seems more geared for removing multiple
users at once (which is a good thing) but doesn't actually work without
this change:

--- a/tests/test_xmlrpc/test_user_plugin.py
+++ b/tests/test_xmlrpc/test_user_plugin.py
@@ -358,7 +358,7 @@ class test_user(Declarative):
loginshell=[u'/bin/sh'],
objectclass=objectclasses.user,
sn=[u'User2'],
- uid=[user1],
+ uid=[user2],
uidnumber=[fuzzy_digits],
ipauniqueid=[fuzzy_uuid],
dn=u'uid=tuser2,cn=users,cn=accounts,' + api.env.basedn,

So NACK for now but its very close.

rob

Version 3 attached.

Added a test case for searching private groups and fixed user tests.

Pavel

ack, pushed to master

_______________________________________________
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel

Reply via email to