On Wed, 20 Oct 2010 22:25:26 -0400
Rob Crittenden <rcrit...@redhat.com> wrote:

> Simo Sorce wrote:
> >
> > In some Fedora versions /etc/sysconfig/ntpd has OPTIONS scattered on
> > multiple line through shell expansion.
> > Handle simple cases like that.
> >
> > Simo.
> 
> I think this will work, it's just one heck of a parser. Is something 
> like the attached a simpler approach?
> 
> My version always adds the new options to the first OPTIONS block,
> I'm not sure if it matters.

Your solution looks a lot smaller indeed.
And less is more here!
I will produce a new patch inspired by this code and post it.
Self-nack on the current patch.

Simo.

-- 
Simo Sorce * Red Hat, Inc * New York

_______________________________________________
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel

Reply via email to