Pavel Zuna wrote:
On 10/20/2010 11:42 PM, Rob Crittenden wrote:
Pavel Zuna wrote:
On 10/14/2010 03:30 PM, Rob Crittenden wrote:
Pavel Zuna wrote:
There was no default value set even though we were using config.get
and
it was throwing exceptions if someone deleted one of the related
config
values.

Pavel

Is this needed since get_ipa_config() will always return something for
time and search limits?

rob

Yes, because get_ipa_config will return defaults for time and search
limits only when the whole ipaConfig entry isn't found.

I reworked the patch, so that defaults are always returned by
get_ipa_config, but I left changes from the previous version, because it
doesn't hurt anything and is a (very little) bit safer.

New version attached.

Pavel

I see your point. One can do 'ipa config-mod --searchtimelimit=` and
blam, everything stops working. This still seems like a bit of a
cover-up fix for that. Should we prevent these attributes from being
removed?

We could do that, but it's always possible to delete the attribute using
ldapmodify or some other tool.


rob

Pavel

Ok, your patch certainly won't hurt anything. Ack.

rob

_______________________________________________
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel

Reply via email to