On 12/17/2010 04:43 PM, Adam Young wrote:
Saw three things that I fixed with one line patches:


1. When browsing page unauthorized.html from firefox4, It showed a blank screen, but with what looked like valid source. turns out, the title open tag was closed with an h2, which didn't match. Rendered fine on firefox3, but not on 4.

2. The link for kerberos time out was the generic "hoiw to configure the browser" page as opposed to the file unauthorized.html which actually performs the configuration.

3. The text for the kinit timeout message read 'run KInit' but the command is kinit. Fixed the capitalization.

_______________________________________________
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel

From 22b2cbbe448d66943f78a04e47c1e10a88d3e64b Mon Sep 17 00:00:00 2001
From: Adam Young <ayo...@redhat.com>
Date: Fri, 17 Dec 2010 16:07:09 -0500
Subject: [PATCH 1/3] type prevented rendering on firefox4

---
 install/html/unauthorized.html |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/install/html/unauthorized.html b/install/html/unauthorized.html
index 6ba8a99..64a891c 100644
--- a/install/html/unauthorized.html
+++ b/install/html/unauthorized.html
@@ -1,5 +1,5 @@
 <html>
-<title>Kerberos Authentication Failed</h2>
+<title>Kerberos Authentication Failed</title>
 <body>
 <h2>Kerberos Authentication Failed</h2>
 <p>
-- 
1.7.2.3

From 00ebf8c4e35029bec0a54417e833eb808136c6ec Mon Sep 17 00:00:00 2001
From: Adam Young <ayo...@redhat.com>
Date: Fri, 17 Dec 2010 16:10:04 -0500
Subject: [PATCH 2/3] error link
 Change the link in the error message to the one that will actually fix the problem

---
 install/static/ipa.js |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/install/static/ipa.js b/install/static/ipa.js
index a7c0658..fee5110 100644
--- a/install/static/ipa.js
+++ b/install/static/ipa.js
@@ -325,9 +325,9 @@ function ipa_cmd(name, args, options, win_callback, fail_callback, objname, comm
             }else{
                 error_thrown.message =
                     "Your kerberos ticket no longer valid."+
-                    "Please run KInit and then click 'retry'"+
+                    "Please run Init and then click 'retry'"+
                     "If this is your first time running the IPA Web UI"+
-                    "<a href='/ipa/errors/ssbrowser.html'> "+
+                    "<a href='/ipa//config/unauthorized.html'> "+
                     "Follow these directions</a> to configure your browser."
             }
         }
-- 
1.7.2.3

From 67d1c0711283e840a68597e119daabbf3d090872 Mon Sep 17 00:00:00 2001
From: Adam Young <ayo...@redhat.com>
Date: Fri, 17 Dec 2010 16:36:48 -0500
Subject: [PATCH 3/3] kinit typo
 Was origially KInit  but the command is kinit

---
 install/static/ipa.js |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/install/static/ipa.js b/install/static/ipa.js
index fee5110..b6750c8 100644
--- a/install/static/ipa.js
+++ b/install/static/ipa.js
@@ -325,7 +325,7 @@ function ipa_cmd(name, args, options, win_callback, fail_callback, objname, comm
             }else{
                 error_thrown.message =
                     "Your kerberos ticket no longer valid."+
-                    "Please run Init and then click 'retry'"+
+                    "Please run kinit and then click 'retry'"+
                     "If this is your first time running the IPA Web UI"+
                     "<a href='/ipa//config/unauthorized.html'> "+
                     "Follow these directions</a> to configure your browser."
-- 
1.7.2.3

_______________________________________________
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel

Reply via email to