-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 01/10/2011 10:54 AM, Martin Kosek wrote:
> Fix "--realm" parameter processing in ipa-rmkeytab. Also make sure
> that memory allocated in this process is freed.
>
> https://fedorahosted.org/freeipa/ticket/711
>
>
Nack,
same comment as the previous patch, don't use if(ptr) free(ptr);
Also one very minor style issue - please use:
if(cond) {
foo();
} else {
bar();
}
rather than:
if (cond) {
foo();
}
else {
bar();
}
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/
iEYEARECAAYFAk0q9lIACgkQHsardTLnvCUk6wCdFyjOz+fy0e7OPcQHdZQBu4xa
leoAoOSVMLJE9X6+TO2R9CN8iZaWqY+3
=Ni7/
-----END PGP SIGNATURE-----
_______________________________________________
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel
