-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 01/13/2011 09:19 PM, Simo Sorce wrote:
> On Thu, 13 Jan 2011 20:19:13 +0100
> Jakub Hrozek <jhro...@redhat.com> wrote:
> 
>> I only found two issues in the winsync codepatch (which I didn't
>> test):
>>
>> +            ad_conn = ipaldap.IPAdmin(ad_dc_name, port=636,
>> cacert=cacert)
>> +            ad_conn = do_simple_bind(binddn=ad_binddn, bindpw=ad_pwd)
>>
>> I think the second line should say ad_conn.do_simple_bind()
>>
>> and:
>>
>> +        self.basic_replication_setup(self.conn, replica_id)
>>
>> basic_replication_setup() takes 4 parameters now.
> 
> Fixed both, thanks for catching these ones!
> 
> Attched 0044-2 patch, the others rebase on top cleanly, so I'll keep
> those acks :-)
> 
> Simo.
> 

Ack

Although probably after yesterday's patches I had to do a 3-way merge on
patch #47, so please check it merges OK.

        Jakub
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/

iEYEARECAAYFAk0wOQwACgkQHsardTLnvCUxegCgui95tx8lwLxufH3SujMBewLI
9lkAoN74s6/QAw4PoASujmSLtf/yoXjw
=BN95
-----END PGP SIGNATURE-----

_______________________________________________
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel

Reply via email to