On Mon, 2011-04-11 at 14:00 -0400, Rob Crittenden wrote:
> Martin Kosek wrote:
> > On Fri, 2011-04-08 at 13:07 -0400, Rob Crittenden wrote:
> >> Martin Kosek wrote:
> >>> I don't think it is a good idea to have this option in
> >>> ipa-client-install --help at all.
> >>>
> >>> Since it is not intended to be used by the user and we just use it in
> >>> our scripts why would we want to have it in ipa-client-install --help or
> >>> man pages? We could just hide it using help=optparse.SUPPRESS_HELP
> >>> attribute for the option and document it only in the installation script
> >>> source.
> >>>
> >>> Martin
> >>>
> >>> On Mon, 2011-04-04 at 17:23 -0400, Rob Crittenden wrote:
> >>>> Make it clear that --on-master is for install scripts only.
> >>>>
> >>>> ticket 1050
> >>
> >> An excellent idea. See new patch.
> >>
> >> rob
> >
> > Nicely done - we won't confuse the user anymore.
> >
> > I have a one more issue I didn't notice in the first review - why should
> > we allow non-root to run ipa-client-install? It fails in this case. I
> > guess this change slipped in the patch only by accident.
> >
> > Martin
> >
> 
> Yeah, updated patch attached.
> 
> rob

ACK. Pushed to master, ipa-2-0.

Martin

_______________________________________________
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel

Reply via email to