From 472d1828957795b60df0d409ba29b1755fb921d5 Mon Sep 17 00:00:00 2001
From: Adam Young <ayo...@redhat.com>
Date: Thu, 16 Jun 2011 15:37:27 -0400
Subject: [PATCH] test dirty onchange

instead of blindly setting dirty, check if the filed has a different value than it originally did.

https://fedorahosted.org/freeipa/ticket/1337
---
 install/ui/aci.js    |    6 +++---
 install/ui/widget.js |   12 ++++++------
 2 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/install/ui/aci.js b/install/ui/aci.js
index 70fe6d9258b6a495bec0a73ce6f22d7b6f5fdb56..077cbebdc00fa8da759ad9aeaea1ee6e236582a1 100644
--- a/install/ui/aci.js
+++ b/install/ui/aci.js
@@ -234,7 +234,7 @@ IPA.attributes_widget = function(spec) {
                 click: function(){
                     $('.aci-attribute', that.table).
                         attr('checked', $(this).attr('checked'));
-                    that.set_dirty(true);
+                    that.set_dirty(that.test_dirty());
                 }
             })
         })).append($('<th/>', {
@@ -298,7 +298,7 @@ IPA.attributes_widget = function(spec) {
                 value: value,
                 'class': 'aci-attribute',
                 click: function() {
-                    that.set_dirty(true);
+                    that.set_dirty(that.test_dirty());
                 }
             }));
             td =  $('<td/>').appendTo(aci_tr);
@@ -335,7 +335,7 @@ IPA.attributes_widget = function(spec) {
                     value: value,
                     'class': 'aci-attribute',
                     change: function() {
-                        that.set_dirty(true);
+                        that.set_dirty(that.test_dirty());
                     }
                 }));
 
diff --git a/install/ui/widget.js b/install/ui/widget.js
index 14a40a577bf23fca32e5218b68aa141e6e7099cf..80906a2f5981fe69d2d32c605dc7fe3c40d87c80 100644
--- a/install/ui/widget.js
+++ b/install/ui/widget.js
@@ -728,7 +728,7 @@ IPA.checkbox_widget = function (spec) {
 
         var input = $('input[name="'+that.name+'"]', that.container);
         input.change(function() {
-            that.set_dirty(true);
+            that.set_dirty(that.test_dirty());
         });
 
         var undo = that.get_undo();
@@ -802,7 +802,7 @@ IPA.checkboxes_widget = function (spec) {
 
         var input = $('input[name="'+that.name+'"]', that.container);
         input.change(function() {
-            that.set_dirty(true);
+            that.set_dirty(that.test_dirty());
         });
 
         var undo = that.get_undo();
@@ -880,7 +880,7 @@ IPA.radio_widget = function(spec) {
 
         var input = $('input[name="'+that.name+'"]', that.container);
         input.change(function() {
-            that.set_dirty(true);
+            that.set_dirty(that.test_dirty());
         });
 
         var undo = that.get_undo();
@@ -957,7 +957,7 @@ IPA.select_widget = function(spec) {
 
         that.select = $('select[name="'+that.name+'"]', that.container);
         that.select.change(function() {
-            that.set_dirty(true);
+            that.set_dirty(that.test_dirty());
         });
 
         var undo = that.get_undo();
@@ -1575,7 +1575,7 @@ IPA.entity_select_widget = function(spec) {
         that.entity_select = $('<select/>', {
             id: that.name + '-entity-select',
             change: function(){
-                that.set_dirty(true);
+                that.set_dirty(that.test_dirty());
             }
         }).appendTo(container);
 
@@ -1586,7 +1586,7 @@ IPA.entity_select_widget = function(spec) {
             style: 'display: none;',
             keyup: function(){
                 populate_select();
-                that.set_dirty(true);
+                that.set_dirty(that.test_dirty());
             }
         }).appendTo(container);
 
-- 
1.7.5.2

_______________________________________________
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel

Reply via email to