On 06/29/2011 04:47 PM, Adam Young wrote:
On 06/29/2011 12:52 PM, Endi Sukma Dewata wrote:
On 6/29/2011 11:30 AM, Adam Young wrote:
On 06/29/2011 10:34 AM, Adam Young wrote:
On 06/29/2011 09:37 AM, Adam Young wrote:
Better solution than the algorithm in 256 for nested entities.
Changes for Hyphen and pkey names

Some issues:

1. This statement will store undefined values into url_state:

       url_state[key_name] = state[key_name];

   We need to check whether the state[key_name] is undefined.
   To test, open the UI, click the 'User Group' tab.

2. The following line should be located outside the for loop that
   iterates through the key names for that entity:

       current_entity = current_entity.containing_entity;

   This will cause a problem when there are more than 1 key name.

3. Optionally, the get_key_names() could just return 'pkey' instead
   of the full '<entity name>-pkey'. The navigation code can add the
   prefix.



_______________________________________________
Freeipa-devel mailing list
[email protected]
https://www.redhat.com/mailman/listinfo/freeipa-devel
ACKed in IRC by edewata and pushed to master with a minor tweak for a JSL warning
_______________________________________________
Freeipa-devel mailing list
[email protected]
https://www.redhat.com/mailman/listinfo/freeipa-devel

Reply via email to