Martin Kosek wrote:
On Tue, 2011-07-12 at 09:52 -0400, Rob Crittenden wrote:
Alexander Bokovoy wrote:
On 12.07.2011 14:51, Martin Kosek wrote:
On Fri, 2011-07-01 at 15:41 -0400, Rob Crittenden wrote:
I found a few test failures that have resulted from some recent commits.
These got lost in the mix of "expected" failures when I did initial
testing on them. This has inspired me to try to fix all the test
failures (see patch 817 too).

This fixes:
- an error in a new exception example
- the case of boolean values in nsAccountLock
- a change in the updater code

rob

Patches 814 and 815 look OK but 816 will conflict with Alexander's patch
0001 (2) from Thursday which deals with nsaccoutlock too and fixes
relevant tests. I got some nsaccountlock with master branch + 816
anyway.

I would let all patch 0001 to handle all nsaccountlock test issues.
Yes, 0001 (2) was a follow up to fix all the issues noticed in 816. I
would rather use that one as it also fixes UI parts.

I checked by rebasing to current git that nothing has changed since
Thursday and patch applies.

Ok, I'm fine with that. Just to be clear, ACK on 814 and 815?

rob


Correct.

Martin


Ok, both pushed to master

_______________________________________________
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel

Reply via email to