JR Aquino wrote:
On Jul 19, 2011, at 2:20 AM, Martin Kosek wrote:

On Mon, 2011-07-18 at 23:43 +0000, JR Aquino wrote:
https://fedorahosted.org/freeipa/ticket/1309

Added .update file to correct the sudo schema during freeipa updates on older 
systems.
Modified Makefile.am to account for new .update file.


NACK.

This fixes the schema well, but sudoRunAsGroup attribute is still filled
incorrectly. I think that the sudo LDAP compat plugin has to be fixed
too. These 2 rules look suspicious:

schema-compat-entry-attribute: sudoRunAsGroup=%{ipaSudoRunAsExtGroup}
schema-compat-entry-attribute: sudoRunAsGroup=%deref("ipaSudoRunAs","cn")

And one more minor issue I saw, please fix indentation in Makefile.am.

Fixed indentation from spaces to tabs.

Also removed trailing whitespace.


ack, pushed to master and ipa-2-0

_______________________________________________
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel

Reply via email to