Martin Kosek wrote:
On Tue, 2011-07-19 at 16:41 -0400, Rob Crittenden wrote:
With the external user/group management fixed, correct the unit tests.
The unit tests were incorrectly expecting the removed data back when
removing external users.
rob
NACK
There is still one unit test failure. Test
"test_a_sudorule_add_externaluser" needs to be fixed as well.
Martin
Wow, not sure how I missed this one. Updated patch attached.
rob
>From 8b1e8d090e1318a7a7d8b8814bf2c034cdd68917 Mon Sep 17 00:00:00 2001
From: Rob Crittenden <rcrit...@redhat.com>
Date: Tue, 19 Jul 2011 16:39:40 -0400
Subject: [PATCH] With the external user/group management fixed, correct the unit tests.
The unit tests were incorrectly expecting the removed data back when
removing external users.
---
tests/test_xmlrpc/test_sudorule_plugin.py | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/tests/test_xmlrpc/test_sudorule_plugin.py b/tests/test_xmlrpc/test_sudorule_plugin.py
index c428899..a079de7 100644
--- a/tests/test_xmlrpc/test_sudorule_plugin.py
+++ b/tests/test_xmlrpc/test_sudorule_plugin.py
@@ -280,7 +280,7 @@ class test_sudorule(XMLRPC_test):
assert ret['completed'] == 1
failed = ret['failed']
entry = ret['result']
- assert 'externaluser' not in entry
+ assert entry['externaluser'] == ()
def test_a_sudorule_add_runasexternaluser(self):
"""
@@ -306,7 +306,7 @@ class test_sudorule(XMLRPC_test):
assert ret['completed'] == 1
failed = ret['failed']
entry = ret['result']
- assert 'ipasudorunasextuser' not in entry
+ assert entry['ipasudorunasextuser'] == ()
def test_a_sudorule_add_runasexternalgroup(self):
"""
@@ -332,7 +332,7 @@ class test_sudorule(XMLRPC_test):
assert ret['completed'] == 1
failed = ret['failed']
entry = ret['result']
- assert 'ipasudorunasextgroup' not in entry
+ assert entry['ipasudorunasextgroup'] == ()
def test_a_sudorule_add_option(self):
"""
--
1.7.4
_______________________________________________
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel
