On Fri, 2011-07-29 at 11:42 +0300, Alexander Bokovoy wrote:
> https://fedorahosted.org/freeipa/ticket/1368
> 
> also replaces a tab by spaces in one else statement (cosmetic).

This works fine. But I have few suggestion for improvement:

1) Shouldn't we also run `hostname NEW_HOSTNAME` so that the new
hostname is properly set on the system?

2) I would enhance our man pages/help and state that we are changing the
system hostname. Current --hostname option is confusing:

       --hostname
              The hostname of this server (FQDN).  By  default  of  nodename  
from
              uname(2) is used.

Martin

_______________________________________________
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel

Reply via email to