On 9/12/2011 7:24 AM, Petr Vobornik wrote:
On 09/10/2011 02:20 AM, Endi Sukma Dewata wrote:
The optional uid field in user's adder dialog did not appear when
the link is clicked to show the field. This is a regression introduced
in the patch for ticket #1648.

The click handler for the link field has been moved into a new closure
so that the variables point to the correct elements.

Note: the duplicate code in IPA.details_table_section.create() and
IPA.dialog.create() will be addressed separately in ticket #1394.

ACK

Pushed to master and ipa-2-1.

But:
The part of code in details.js is never executed because field.optional
is never set to true for fields in details facet. As you write, some
clean-up should be addressed in #1394 or/and in #1696 (to be consistent
with dialogs).

That's true. The code is being kept consistent in these locations to simplify merging in my next patch for #1394. For #1696 depending on UXD feedback we might need to change this code again.

--
Endi S. Dewata

_______________________________________________
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel

Reply via email to