On Mon, 2011-09-12 at 17:49 +0300, Alexander Bokovoy wrote:
> On Mon, 12 Sep 2011, Martin Kosek wrote:
> > Good job! This all looks very good, I found no installation error in
> > various scenarios I tried. I only found a problem with mixed tabs-spaces
> > indentation. You introduced it at least in install/tools/ipactl. You can
> > easily check these cases with:
> > 
> > $ ./make-lint --enable-noerror | grep W0312
> > ipa-client/ipa-install/ipa-client-install:221: [W0312] Found indentation 
> > with tabs instead of spaces
> > ipa-client/ipa-install/ipa-client-install:237: [W0312] Found indentation 
> > with tabs instead of spaces
> > ...
> > install/tools/ipactl:194: [W0312] Found indentation with tabs instead of 
> > spaces
> > install/tools/ipactl:203: [W0312] Found indentation with tabs instead of 
> > spaces
> > install/tools/ipactl:241: [W0312] Found indentation with tabs instead of 
> > spaces
> > ...
> > 
> > We don't have to fix the old indentation problems right in your patches
> > but we should not introduce new tab-spaces problems as they have a
> > potential to cause nasty problems.
> I believe I fixed all whitespace problems, old and new. I eneded up 
> with a separate commit due to scale of it. It is pushed to both 
> platform and platform-master branches on fedorapeople repo.
> 

ACK for fixed patches in the tree. Pushed to master.

I didn't push your last whitespace cleanup patch for
ipapython/dnsclient.py because it introduces 8 space indentation instead
of our standard 4 space.

Martin

_______________________________________________
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel

Reply via email to