On Wed, 2011-09-14 at 11:29 -0400, Rob Crittenden wrote:
> Martin Kosek wrote:
> > On Wed, 2011-09-14 at 14:23 +0200, Martin Kosek wrote:
> >> On Tue, 2011-09-13 at 14:35 -0400, Rob Crittenden wrote:
> >>> Add an escape clause to the CSR validator in the cert plugin. If the csr
> >>> is a file just return and let the load_files() call slurp in the
> >>> contents. It will still get validated.
> >>>
> >>> rob
> >>
> >> This works fine for CSR file.
> >>
> >> Shouldn't we fix this also for other File params? For example,
> >> entitle-import command will be affected as well:
> >>
> >>      takes_args = (
> >>          File('usercertificate*', validate_certificate,
> >>              cli_name='certificate_file',
> >>          ),
> >>      )
> >>
> >> We can create a separate ticket for entitle-import if you want.
> >>
> >> Martin
> >
> > Oh, and one more thing - API.txt has to be updated since you added a
> > label to the CSR parameter.
> >
> > Martin
> >
> 
> Updated patch with API attached. I had that fixed, dropped my changes, 
> re-made them and forgot to update API again.
> 
> entitle-import doesn't have stdin_if_missing set so will only read from 
> a file, there is no interactive option.
> 
> rob

ACK. Pushed to master, ipa-2-1.

Martin

_______________________________________________
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel

Reply via email to