On Mon, 31 Oct 2011, Jan Cholasta wrote:
> Added finalization for __call__ and the check for CLI. Patch attached.
ACK from my side but see below.

> +    def __getattribute__(self, name):
> +        if not name.startswith('_Plugin__') and not 
> name.startswith('_ReadOnly__') and name != 'finalize_late':
> +            self.finalize_late()
> +        return object.__getattribute__(self, name)
Could you get faster than three string comparisons? As 
__getattribute__ is fairly often called it would make sense to keep 
these operations to absolute minimum.

/ Alexander Bokovoy

Freeipa-devel mailing list

Reply via email to