I couldn't find a clear ACK for this patch but it has been pushed as

Guys please try to better report on the list when patches are pushed and
close the thread.


On Thu, 2011-09-29 at 14:52 +0200, Petr Vobornik wrote:
> On 09/27/2011 10:54 PM, Endi Sukma Dewata wrote:
> > On 9/27/2011 7:50 AM, Petr Vobornik wrote:
> >> I've added padding and unified font-weight in error-message style. The
> >> padding is added because text of the message was right on the border
> >> which wasn't much readable. Font-weight is added because sometimes it
> >> inherits font-weight from other style and so it is inconsistent with
> >> other appearances. I'm not sure about the 'bold', though.
> >
> > This is good but can we use a new CSS class for the error message? I'd
> > rather not change the jquery-ui.css (removing white spaces is ok)
> > because it will be difficult to keep track the changes if we need to
> > upgrade it.
> Moved this change to ipa.css (no need to add extra class, it will 
> overwrite it as long ipa.css is linked after jquery-ui.css).
> >
> > There's another minor issue, but this one can be fixed separately if you
> > want. Try editing a self-service permission, uncheck all attributes,
> > then click Update. The undo link and the error message appear in 2
> > separate lines.
> Kept them on 2 lines.
> > I think it's better to show them in a single line. When
> > we fix the attributes widget to inherit from table, they will fit into
> > the footer.
> I agree.
> > The padding should be consistent as well, right now the undo
> > box is smaller than the error message.
> Added padding to undo. Added 1px margin-bottom to undo to separate undo 
> and error message borders when they are on two lines.
> Changed display of undo in attributes_widget from inline to inline-block 
> - looks better with added padding.
> _______________________________________________
> Freeipa-devel mailing list
> Freeipa-devel@redhat.com
> https://www.redhat.com/mailman/listinfo/freeipa-devel

Simo Sorce * Red Hat, Inc * New York

Freeipa-devel mailing list

Reply via email to