Seeing some new make-lint failures after the reworking of ipaldap function signatures;

$ ./make-lint
ipaserver/install/adtrustinstance.py:101: [E1120, ADTRUSTInstance.__create_samba_user] No value passed for parameter 'modlist' in function call ipaserver/install/adtrustinstance.py:190: [E1120, ADTRUSTInstance.__create_samba_domain_object] No value passed for parameter 'modlist' in function call ipaserver/install/adtrustinstance.py:198: [E1120, ADTRUSTInstance.__create_samba_domain_object] No value passed for parameter 'modlist' in function call


I wonder if the signature needs to be:

    def add_s(self, dn, modlist=None):

For the case were dn isn't an Entry we probably need to raise an exception if modlist is None (or test to see what python-ldap add_s does).

rob

_______________________________________________
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel

Reply via email to