On Tue, Nov 29, 2011 at 11:25:41PM +0200, Alexander Bokovoy wrote:
> On Tue, 29 Nov 2011, Sumit Bose wrote:
> > @@ -199,10 +216,11 @@ class ADTRUSTInstance(service.Service):
> >                  self.admin_conn.addEntry(entry)
> >  
> >          entry = ipaldap.Entry(self.smb_dom_dn)
> > -        entry.setValues("objectclass", ["sambaDomain", "nsContainer"])
> > +        entry.setValues("objectclass", [self.OBJC_DOMAIN, "nsContainer"])
> >          entry.setValues("cn", self.domain_name)
> > -        entry.setValues("sambaDomainName", self.netbios_name)
> > -        entry.setValues("sambaSID", self.__gen_sid_string())
> > +        entry.setValues(self.ATTR_FLAT_NAME, self.netbios_name)
> > +        entry.setValues(self.ATTR_SID, self.__gen_sid_string())
> > +        entry.setValues(self.ATTR_GUID, str(uuid.uuid4()))
> >          #TODO: which MAY attributes do we want to set ?
> >          self.admin_conn.add_s(entry)
> Could you please also convert this one to .addEntry(entry)?
> I think it is the last one left...

This is fixed in freeipa-sbose-0012-3-Fix-some-pylint-warnings.patch.

Martin, shall I extract the add_s->addEntry changes into a separate
patch so the they can reviewed indepently of the 6 ipasam patches?

bye,
Sumit

> 
> -- 
> / Alexander Bokovoy

_______________________________________________
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel

Reply via email to