Ondrej Hamada wrote:
On 01/26/2012 09:24 AM, Jan Cholasta wrote:
Dne 25.1.2012 17:50, Ondrej Hamada napsal(a):
https://fedorahosted.org/freeipa/ticket/2161

The option '--no-reverse' was not honoured in replica-install because of
wrongly placed condition checking.


NACK

The --no-reverse options means "do not create new reverse zone if
there is no existing suitable reverse zone". Your patch changes the
semantics of the option to "do not use any reverse zone".

One problem I see is that the name of the option is misleading. It
should probably be changed to "--no-new-reverse".

Anyway, the ticket should IMO be closed as invalid. It is a case of
people not reading documentation and then being surprised why things
don't work the way they assumed.

Honza

According to discussion with jgalipea and rcrit: the option will stay as
it is, just the manpages and documentation will be updated.

This patch patches the option descriptions in code and in manpages. For
documentation update was created a new ticket:
https://fedorahosted.org/freeipa/ticket/2330

ACK, pushed to master and ipa-2-2

_______________________________________________
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel

Reply via email to