On Thu, 2012-03-01 at 16:26 -0500, Rob Crittenden wrote:
> Martin Kosek wrote:
> > On Wed, 2012-02-29 at 11:20 +0100, Petr Viktorin wrote:
> >> On 02/27/2012 06:31 PM, Martin Kosek wrote:
> >>>
> >>> 4) Minor change:
> >>> -                except Exception:
> >>> +                except:
> >>>
> >>
> >> Don't do that. It would for example disable Ctrl+C by trapping
> >> KeyboardInterrupt.
> >>
> >> PEP8 has a paragraph on this, search for 'except Exception:'
> >>
> >>
> >
> > Good to know, thanks. Rob, in that case please ignore issue #4.
> >
> > Martin
> 
> Updated patch attached.
> 
> rob

This does not look like the right patch.

Martin

_______________________________________________
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel

Reply via email to