Jan Cholasta wrote:
On 23.4.2012 17:21, Jan Cholasta wrote:
On 16.4.2012 22:51, Nalin Dahyabhai wrote:
The ethers.byname and ethers.byaddr NIS maps pair host names and
hardware network addresses. This should close ticket #2259.

Nalin


Please add this to install/updates/50-nis.update as well.

Besides that, ACK on all 3 patches. I have checked only if ypcat and
ypmatch work as expected, I would prefer if someone with more LDAP/NIS
knowledge took a look at the patches before pushing them.

Honza


I have just noticed one issue: we allow the octets in MAC addresses to
be separated not only by ":", but also by "|", "\" or "-". Your patch
doesn't seem to work for MAC addresses not using ":" as a separator:

$ ipa host-mod host.example.com --macaddress 00:11:22:33:44:55

$ ypcat ethers
00:11:22:33:44:55 host.example.com

$ ipa host-mod host.example.com --macaddress 00-11-22-33-44-55

$ ypcat ethers
<nothing>

Honza


We can always change that if need be. I made the regex rather generous.

rob

_______________________________________________
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel

Reply via email to