On 05/23/2012 08:03 PM, Rob Crittenden wrote:
Petr Viktorin wrote:
On 2012-05-18 17:53, Rob Crittenden wrote:
We don't have an explicit requires on the policycoreutils package in the
client because SELinux is not required (just recommended).

SELinux can be enabled without this package so check for that condition
and don't allow installation if it is the case. The resulting install
will be rather broken.

Also check on the server when installing. This should never happen but
in theory it could do the server install then fail in the client because
of this.


All other platform-dependent services have a default defined in
ipapython/services.py.in. Shouldn't check_selinux_status have one, too?

Yes, you're right, I forgot to add that.

Patch updated.


Unfortunately, the patch doesn't apply.

I also found a comment typo in ipapython/platform/redhat.py & ipapython/platform/fedora.py:

+# Everything else is made available through these symbols when they directly
+# imported into ipapython.services:

s/they directly/they are directly/


Freeipa-devel mailing list

Reply via email to