On Thu, 2012-06-07 at 10:56 +0300, Alexander Bokovoy wrote:
> On Thu, 07 Jun 2012, Martin Kosek wrote:
> >It may have been an issue on my side. I will open a ticket if I hit a
> >unit test error again.
> >
> >I did a next round of review for your patches, I did not find any
> >show-stopper why not to push your patches. Lets get them grilled also by
> >other team members :-)I just logged one issue I found with
> >ipa-adtrust-install:
> >https://fedorahosted.org/freeipa/ticket/2815
> I think we should do check on whether we he valid ticket prior to do
> configuration, similar to how we do check DM password availability.
> Besides the keytab fetch we also need to create the service which
> requires appropriate admin permissions.
> >ACK. Pushed all 13 patches to master.
> Great! Thanks for the thorough review.

Excellent news!
Thanks a lot to all involved for the great work done!


> Sumit, please rebase and send your remaining patches for review.

Simo Sorce * Red Hat, Inc * New York

Freeipa-devel mailing list

Reply via email to