Petr Viktorin wrote:
On 06/12/2012 11:14 PM, Rob Crittenden wrote:
Petr Viktorin wrote:
I went through all the output/debug messages in ipa-client-install,
removed duplicates, and routed them through the log manager.
I used these log levels:
DEBUG - detailed messages the user probably doesn't want to see (only
printed to console with --debug)
INFO - progress reports ("Configured /etc/sssd/sssd.conf") and
instructions ("You may need to restart services or reboot the machine.")
WARNING - something unusual that may require attention
ERROR - something went wrong
Obviously there's some overlap there.
On the console, the messages are now prefixed with the log level. This
should bring attention to the warnings/errors.
Does this format look okay?
I think the current default console_format, which prefixes the logger
name (ipa) and the level, is too verbose.
I agree. I'm not a fan of printing the log level, it is very distracting.
I've removed the log level.
This is a good start but the DNS discovery area needs more work. I've
found it very difficult to look at a log and figure out where the domain
and hostname came from (user provided or discovered?) and trace how the
discovery is working. There is currently a lot of smoke and noise and
very little useful information.
I've added the sources of the values to the summary, and provided more
tracing information.
I put this in a separate patch; it's not the almost mechanical changes
as in the first one. I'll be happy to squash them if that would make
review easier.
rob
ACK. Both pushed to master.
rob
_______________________________________________
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel
