On 07/13/2012 01:17 PM, Adam Tkac wrote:
On Tue, Jul 10, 2012 at 03:15:03PM +0200, Petr Spacek wrote:
this patch adds an debug message to ldap_cache_addrdatalist().
It is very useful for persistent search debugging.
although idea of the patch is fine, I don't think that statements which allocate
memory should be in the "cleanup" path.
What about this (generally used in BIND):
dns_name_format(name, namebuf, sizeof(namebuf));
log_debug(20, "%s", namebuf);
Or you can put this entire code into "if (isc_log_debuglevel() >= 20)" statement
to save some CPU cycles...
It is definitely good idea. I forgot to upper-limit for DNS names.
Revised patch was pushed to master:
Freeipa-devel mailing list