On 07/13/2012 03:42 PM, Adam Tkac wrote:
On Tue, Jul 10, 2012 at 03:57:24PM +0200, Petr Spacek wrote:
Hello,

these patches provides SOA serial auto-increment feature for external changes.
Related ticket: https://fedorahosted.org/bind-dyndb-ldap/ticket/67

It is necessary to set "psearch" AND "serial_autoincrement" to "yes"
in /etc/named.conf to enable this feature.

In replicated environment idnsSOAserial attribute has to be declared
as non-replicated. It is done by mkosek's patch 281 for 389 DS &
FreeIPA.

For testing purposes it is enough to add "idnsSOAserial" to end of
exclude list in nsDS5ReplicatedAttributeList attribute for each
replication agreement located in cn=mapping tree,cn=config subtree.


My patch 28 contains "trick" necessary for replicated environments
with 389 DS. 389 sends entry change notification (ECN) in cases when
non-replicated attribute idnsSOAserial was changed on *other side*.
In that case no change is visible in DNS attributes, but ECN is sent
by 389. (Attribute modifyTimestamp is changed also.)

Patch 28 computes digest/hash from all resource records in idnsZone
object and compares old and new digest after each received ECN. This
approach eliminates "false changes".

Each patch depends on all preceding patches, but each patch
implements visible (and testable) part of functionality.

Hello Peter,

please check my comments below.

Regards, Adam

Hello,

I did all changes except this one:

+unsigned int
+rdatalist_length(const dns_rdatalist_t *rdlist)

There is no reason to have this function exported, please mark it as static (and
probably also as inline).

rdatalist_length() is used from rdlist.c and ldap_driver.c.

Rebased patches were pushed to master:
https://fedorahosted.org/bind-dyndb-ldap/changeset/99663b6d65cf5dc166b3cb6f83be1878b8de3163
https://fedorahosted.org/bind-dyndb-ldap/changeset/cd37fba03c5c86a766d1a9f893036ac3540e8b7c
https://fedorahosted.org/bind-dyndb-ldap/changeset/9a3f29c12db99597222ffa2bf0713d0b00cb4699
https://fedorahosted.org/bind-dyndb-ldap/changeset/c379d81508fbfa00ecb5da727ff7b097ebb29a3d
https://fedorahosted.org/bind-dyndb-ldap/changeset/93ae7491a80ba8c4789f8770e14c053b67176de4

Petr^2 Spacek

_______________________________________________
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel

Reply via email to