On Wed, 25 Jul 2012, Simo Sorce wrote:
This has grown to more than a one-liner so I seek an active ack.

Simo.

--
Simo Sorce * Red Hat, Inc * New York

From b107bc7c41c3b6dcb714e558890b37f1e3b4bacd Mon Sep 17 00:00:00 2001
From: Simo Sorce <sso...@redhat.com>
Date: Wed, 25 Jul 2012 11:23:11 -0400
Subject: [PATCH] Add all external samba libraries to BuildRequires

Also move them in the right spot (if ! only client) so that they are required
only when building the server.
---
freeipa.spec.in |    5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/freeipa.spec.in b/freeipa.spec.in
index 
45149c65f2333512fe21e40be903a3e6144d7084..ba5707ab0ce067a81e0849133820401b439ca13a
 100644
--- a/freeipa.spec.in
+++ b/freeipa.spec.in
@@ -33,6 +33,10 @@ BuildRequires:  systemd-units
%endif
BuildRequires:  samba4-devel >= 4.0.0-128
BuildRequires:  samba4-python
+BuildRequires:  libtalloc-devel
+BuildRequires:  libtevent-devel
+BuildRequires:  libtdb-devel
+BuildRequires:  libldb-devel
I don't see libtdb and libldb in generated deps anywhere in freeipa rpm packages
so they are probably not needed.

$ readelf -d /usr/lib64/dirsrv/plugins/libipa*.so|grep Shared|cut -d: -f2|sort 
-u
 [libcom_err.so.2]
 [libcrypto.so.10]
 [libc.so.6]
 [libk5crypto.so.3]
 [libkrb5.so.3]
 [liblber-2.4.so.2]
 [libldap_r-2.4.so.2]
 [libndr-nbt.so.0]
 [libndr.so.0]
 [libsamba-util.so.0]
 [libsss_idmap.so.0]
 [libtalloc.so.2]
 [libtevent.so.0]
 [libuuid.so.1]
 [libwbclient.so.0]

$ readelf -d /usr/lib64/samba/pdb/ipasam.so|grep Shared|cut -d: -f2
 [liblber-2.4.so.2]
 [libldap_r-2.4.so.2]
 [libkrb5.so.3]
 [libk5crypto.so.3]
 [libcom_err.so.2]
 [libndr.so.0]
 [libsamba-util.so.0]
 [libtevent.so.0]
 [libtalloc.so.2]
 [libsmbldap.so]
 [libcliauth.so]
 [libpdb.so.0]
 [libsecurity.so]
 [libsmbconf.so.0]
 [libc.so.6]

--
/ Alexander Bokovoy

_______________________________________________
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel

Reply via email to