On 07/27/2012 01:13 PM, Tomas Babej wrote:
Hi,

this patch simply checks if ipa-join exists in ipa-client folder, if not, skips 
tests relying on it.
Uses nose.plugin.skip.

https://fedorahosted.org/freeipa/ticket/2905

Tomas Babej



Hello,
This would be better done in class setup, so you don't have to repeat it in every method. Look at XMLRPC_test.setUpClass() in xmlrpc_test.py for isnpiration.

While you're at it, it would be good to move the mkstemp() call into setUpClass as well, so that importing the module doesn't have unnecessary side effects.

--
PetrĀ³

_______________________________________________
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel

Reply via email to