On 10/09/2012 01:21 PM, Adam Tkac wrote:
On Mon, Oct 08, 2012 at 04:46:54PM +0200, Petr Spacek wrote:
Hello,

     Use automatic connection management in LDAP modification code to
     prevent potential deadlock.

     Without this patch the plugin will deadlock when modify_ldap_common()
     is called with PTR synchronization enabled and only single
     connection is available in the connection pool.

Nack

If I read the patch correctly, it leaves unused ldap_conn parameters in
ldap_modify_do() and modify_soa_record() functions.

Those params are always NULL so they can be safely removed. Please also remove
the "autoconn" variable from ldap_modify_do()

My intent was to keep the same connection management abilities as are in ldap_query(): You can avoid repetitive ldap_pool_get/putconnection() calls by passing connection via parameter.

I can remove it if it isn't worth. (Actually *_modify_*() functions do not use this capability now.)

Petr^2 Spacek


Regards, Adam

 From 5ad686a95510b1584c85d672ec845b27504f746c Mon Sep 17 00:00:00 2001
From: Petr Spacek <pspa...@redhat.com>
Date: Mon, 8 Oct 2012 16:41:40 +0200
Subject: [PATCH] Use automatic connection management in LDAP modification
  code to prevent potential deadlock.

_______________________________________________
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel

Reply via email to