Sumit Bose wrote:
On Mon, Oct 15, 2012 at 04:10:45PM +0300, Alexander Bokovoy wrote:
Hi!

We don't use smbpasswd in adtrustinstance anymore so the check is
bogus.

One-liner.

--
/ Alexander Bokovoy

ACK

NACK. Please fix the error message too. It should be using the variable smbfile and not file.

rob


bye,
Sumit

>From 687f448a4b7d12ddb356f8e2a35a93fe9611b7cb Mon Sep 17 00:00:00 2001
From: Alexander Bokovoy <aboko...@redhat.com>
Date: Mon, 15 Oct 2012 16:01:26 +0300
Subject: [PATCH] Remove bogus check for smbpasswd

We don't use smbpasswd when configuring IPA for AD trusts anymore
because we switched to use Kerberos authentication in IPA passdb
backend based on CIFS service keytab.
---
  ipaserver/install/adtrustinstance.py | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ipaserver/install/adtrustinstance.py 
b/ipaserver/install/adtrustinstance.py
index 
b74f4b685b1cb56bdcdbae15ab6a8f38960bfc66..fcf2a73920567bde26c0df3b4797d727d241b36c
 100644
--- a/ipaserver/install/adtrustinstance.py
+++ b/ipaserver/install/adtrustinstance.py
@@ -60,7 +60,7 @@ and re-run ipa-adtrust-instal again afterwards.
  """

  def check_inst():
-    for smbfile in ['/usr/sbin/smbd', '/usr/bin/net', '/usr/bin/smbpasswd']:
+    for smbfile in ['/usr/sbin/smbd', '/usr/bin/net']:
          if not os.path.exists(smbfile):
              print "%s was not found on this system" % file
              print "Please install the 'samba' packages and " \
--
1.7.12


_______________________________________________
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel

_______________________________________________
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel


_______________________________________________
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel

Reply via email to