On Wed, Oct 17, 2012 at 09:58:36AM -0400, Simo Sorce wrote:
> On Wed, 2012-10-17 at 13:04 +0200, Adam Tkac wrote:
> > Hello,
> > 
> > attached patch hides all symbols except dynamic_driver_{init,destroy}. 
> > Feedback
> > is appreciated.
> 
> Any reason not to use a simple export file ?

This is also possible solution. However if I understand GNU build chain
correctly, using export file only affects linker and doesn't allow compiler to
perform more aggressive optimisations (i.e. inline hidden functions etc), does
it?

> Anyway strong ACK, keeping private symbols private is good hygiene.

Thanks, pushed to master.

Regards, Adam

-- 
Adam Tkac, Red Hat, Inc.

_______________________________________________
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel

Reply via email to