On 10/17/2012 12:02 PM, Petr Vobornik wrote:
> On 10/16/2012 06:10 PM, Endi Sukma Dewata wrote:
>> On 10/12/2012 5:55 AM, Petr Viktorin wrote:
>>> On 10/11/2012 02:55 PM, Petr Vobornik wrote:
>>>> This bunch of patches is a backport of Firefox extension to FreeIPA 2.2.
>>>>
>>>> First apply pvoborni's patches then pviktori's.
>>>
>>> I tested several replication/upgrade scenarios. Upgrading from 2.2.0 and
>>> to master works fine. ACK for the Python part.
>>
>> ACK for the JavaScript part.
> 
> Pushed to ipa-2-2
>>
>> Just a minor issue, there's a typo in ipa_init.json and internal.py, I
>> think it's supposed to use a curly bracket:
>>
>>    http://${host]/ipa/config/unauthorized.html
>>
>> This problem exists on both pvoborni-219-1 and pvoborni-219-2-2 patches.
>>
> Fixed, attaching updated and pushed patch for ipa-2-2. I will send patch for
> 3.0 separately.
> 

I started with IPA 2.2.1 release, but found out that the spec file is not right
and some files are missing:

Processing files: freeipa-debuginfo-2.2.1-0.fc17.x86_64
Checking for unpackaged file(s): /usr/lib/rpm/check-files
/root/freeipa-2-2-0/rpmbuild/BUILDROOT/freeipa-2.2.1-0.fc17.x86_64
error: Installed (but unpackaged) file(s) found:
   /etc/ipa/html/ffconfig.js
   /etc/ipa/html/ffconfig_page.js


RPM build errors:
    Installed (but unpackaged) file(s) found:
   /etc/ipa/html/ffconfig.js
   /etc/ipa/html/ffconfig_page.js
make: *** [rpms] Error 1


Petr, can you please fix the spec file and check if the extension work is
otherwise ok?

Thanks,
Martin

_______________________________________________
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel

Reply via email to