This patch was posted to Trac as
https://fedorahosted.org/freeipa/ticket/3276
It fixes https://fedorahosted.org/freeipa/ticket/2691; I've added the
link to the commit message.
Works fine, ACK. Thank you, Ľubomír!
--
Petr³
From 8adf4d212de3309bdf427a7c853dc19fa15ed658 Mon Sep 17 00:00:00 2001
From: Lubomir Rintel <[email protected]>
Date: Wed, 28 Nov 2012 17:27:23 +0100
Subject: [PATCH] Drop unused readline import
The actual readline usage was removed in commit f19218f7
(Remove duplicate and unused utility code,
https://fedorahosted.org/freeipa/ticket/2650) and the import remained.
Readline should not be initialized if the output is not to terminal (and it
does no checks itself, so import in anything that would be useful to redirect
should be conditional), since it may garble the output [1]:
$ TERM=xterm python -c 'import readline' |hexdump -C
00000000 1b 5b 3f 31 30 33 34 68 |.[?1034h|
00000008
[1] https://bugzilla.redhat.com/show_bug.cgi?id=304181#c1
Fixes https://fedorahosted.org/freeipa/ticket/2691
---
ipapython/ipautil.py | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/ipapython/ipautil.py b/ipapython/ipautil.py
index c444d8c..10ad2c3 100644
--- a/ipapython/ipautil.py
+++ b/ipapython/ipautil.py
@@ -28,7 +28,7 @@ import string
import tempfile
import subprocess
import random
-import os, sys, traceback, readline
+import os, sys, traceback
import copy
import stat
import shutil
--
1.7.1
_______________________________________________
Freeipa-devel mailing list
[email protected]
https://www.redhat.com/mailman/listinfo/freeipa-devel
