On 12/17/2012 04:08 PM, Petr Viktorin wrote:
> https://fedorahosted.org/freeipa/ticket/2482
> The first two patches are rebased from what I sent back in March; the third
> fixes ACIs using targetfilter.

I finally got to your patches. Generally, everything worked like charm, I have
just few minor comments:

- patch needs a rebase
- patch description is confusing, we are talking about RDN "sudocmd" and not 

I would optimize the LDAP calls a little:
1) Use sudorule base DN as a base for the LDAP search
2) Do not call LDAP search twice, but just once and then collect the result.
Now you use 2 LDAP searches with following filters:



We can do just one LDAP search with this filter:


- patch description needs amending: s/CN/SUDOCMD/


Freeipa-devel mailing list

Reply via email to