On 03/07/2013 02:19 PM, Ana Krivokapic wrote:
On 03/07/2013 12:41 PM, Petr Vobornik wrote:
On 03/06/2013 08:26 PM, Ana Krivokapic wrote:
On 03/06/2013 10:40 AM, Petr Vobornik wrote:
On 03/05/2013 05:52 PM, Ana Krivokapic wrote:
On 02/27/2013 05:10 PM, Petr Vobornik wrote:
On 02/27/2013 04:20 PM, Ana Krivokapic wrote:
Add support for Realm Domains to web UI.



Almost there, as discussed in person:

1. following strings should be add to and obtained from internal.py
                 title: 'Check DNS',
                 message: 'Do you also want to perform DNS check?',
                 ok_label: 'Check DNS',

2. the server plugin should report all dns resolution failures, not
just the first one.

Fixed, updated patch is attached.

Works fine, but you forgot to update all related tests (s/domain/domains/):

FAIL: test_realmdomains[8]: realmdomains_mod: Try to replace list of realm domains with a 
list with an invalid domain "doesnotexist.test"
Traceback (most recent call last):
  File "/usr/lib/python2.7/site-packages/nose/case.py", line 197, in runTest
  File "/home/pvoborni/dev/freeipa/tests/test_xmlrpc/xmlrpc_test.py", line 264, in 
    func = lambda: self.check(nice, **test)
  File "/home/pvoborni/dev/freeipa/tests/test_xmlrpc/xmlrpc_test.py", line 278, 
in check
    self.check_exception(nice, cmd, args, options, expected)
  File "/home/pvoborni/dev/freeipa/tests/test_xmlrpc/xmlrpc_test.py", line 304, 
in check_exception
    assert_deepequal(expected.strerror, e.strerror)
  File "/home/pvoborni/dev/freeipa/tests/util.py", line 343, in assert_deepequal
    VALUE % (doc, expected, got, stack)
AssertionError: assert_deepequal: expected != got.

  expected = u"invalid 'domain': no SOA or NS records found for domains: 
  got = u"invalid 'domain': no SOA or NS records found for domain 
  path = ()


Petr Vobornik

Freeipa-devel mailing list

Reply via email to