On 03/13/2013 09:50 AM, Tomas Babej wrote:
> On Wed 13 Mar 2013 09:47:09 AM CET, Tomas Babej wrote:
>> SID validation in idrange.py now enforces exact match on SIDs, thus
>> one can no longer use SID of an object in a trusted domain as a
>> trusted domain SID.
>> Freeipa-devel mailing list
> Just renamed the patch filename to follow the convention.
I do not think that the debug message is needed:
+ root_logger.error('No trusted domain with given SID found, '
+ 'listing SIDS for all the trusted domains:')
+ for domain in self._domains:
+ root_logger.error('SID: %s' % self._domains[domain])
User will not see it anyway and he can easily get list of SIDs/domains with
Otherwise the patch looks and works fine. I would just consider renaming the
method from is_trusted_sid_valid_domain to is_trusted_domain_sid_valid. Sounds
better to me, but I have no strong feelings about that.
Freeipa-devel mailing list