On 02/21/2013 02:39 PM, Martin Kosek wrote: > Thanks Brian. I still see few issues though: > > 1) The patch adds a whitespace error: > > $ git apply ~/freeipa-bcook-0001-Add-DNS-Setup-Prompt-to-Install.patch > /home/mkosek/freeipa-bcook-0001-Add-DNS-Setup-Prompt-to-Install.patch:41: > trailing whitespace. > > warning: 1 line adds whitespace errors > > 2) It does unrelated and unnecessary changes to the main function: > > --- a/install/tools/ipa-server-install > +++ b/install/tools/ipa-server-install > @@ -560,10 +560,16 @@ def set_subject_in_config(realm_name, dm_password, > suffix, subject_base): > conn.disconnect() > > def main(): > + """ > + > + > + :return: > + """ > global ds > global pw_name > global uninstalling > global installation_cleanup > + > ds = None > > safe_options, options = parse_options() > > 3) In the question, I would replace "bind" with "BIND" as this is how the > project should be spelled. I see that few lines above we also refer to BIND > with "bind" (it may have caused the confusion), I think this can be fixed too. > > Martin
Hello Brian, I did not see any response to my mail below so I went ahead and made these fixes myself as we want this in our next release (updated patch attached). ACK. Pushed to master. Martin
From 736088025996d2d2d574ba8ad7f48b5e7d70729a Mon Sep 17 00:00:00 2001 From: Brian Cook <bc...@redhat.com> Date: Thu, 14 Feb 2013 08:49:17 -0800 Subject: [PATCH] Add DNS Setup Prompt to Install Currently the only way to setup integrated DNS is by passing --setup-dns to ipa-server-install. This patch modifies install so that if --setup-dns is not passed, the user is asked if they want to configure integrated dns. http://fedorahosted.org/freeipa/ticket/2575 --- install/tools/ipa-server-install | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/install/tools/ipa-server-install b/install/tools/ipa-server-install index 57511c2147e52c78b1da894a7d7e83e9cb974acf..479894b36ba94f8f6ff2bec4cd1b3e371fddcbff 100755 --- a/install/tools/ipa-server-install +++ b/install/tools/ipa-server-install @@ -750,6 +750,11 @@ def main(): admin_password = "" reverse_zone = None + if not options.setup_dns and not options.unattended: + if ipautil.user_input("Do you want to configure integrated DNS (BIND)?", False): + options.setup_dns = True + print "" + # check bind packages are installed if options.setup_dns: if not bindinstance.check_inst(options.unattended): -- 1.8.1.4
_______________________________________________ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
